fix: persist theme selection across reloads - #49
Merged
Conversation
Comment on lines
+8
to
+13
| <script> | ||
| try { | ||
| if (localStorage.getItem("theme") === "dark") | ||
| document.documentElement.classList.add("dark"); | ||
| } catch (e) {} | ||
| </script> |
Contributor
There was a problem hiding this comment.
Doesn't app JS do it in JS side?
Collaborator
Author
There was a problem hiding this comment.
Yeah, but main.tsx executes just a bit late, and so screen flash is seen when switching to dark mode each time. In case of an inline script, the code executes at once, preventing that from happening. Will add a comment on index.html to explain this better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
What was wrong
What changed
lib/theme.ts.Testing
student-theme.spec.ts: toggles dark, reloads, checks it holds on another page, then toggles back.